SphereServer BugTracker - SphereServer
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002195SphereServerscript packpublic27-08-13 20:5715-10-14 03:30
ReporterCoruja 
Assigned ToCoruja 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version0.56c Nightly 
Nightly VersionAutomated (specify build number)
Experimental FlagsNone
Option FlagsNone
Internal Build Number
Summary0002195: Incorrect behavior on create food spell
DescriptionOn OSI rules, create food spell is not a target based spell. You doesnt need to use the spell and target the ground to create the item on ground, but you just use the spell and the food appears on the backpack without any target


sphere_spells.scp:

[Spell 2]
...
FLAGS=SPELLFLAG_TARG_XYZ //just remove this flag

ON=@Success //and add this (in a hardcoded way)
SERV.NEWITEM <DEF.deffood> //deffood on sphere_defs.scp must be updated with the correct list too (probably this will turn LOCAL.CreateObject obsolete on this spell, replacing it with the working deffood)
NEW.CONT=<SRC.FINDLAYER.layer_pack>
SRC.SYSMESSAGE @,,1 You magically create food in your backpack: <NEW.NAME> //add on sphere_msgs.scp
SRC.SOUND 482 //I cant remember why I'm using the sound here instead snd_spell_create_food setting (sphere_defs.scp). Maybe the sound doesnt works without SPELLFLAG_TARG_XYZ and it must be fixed too
Steps To Reproduce
Additional InformationCorrect deffood setting:
{i_fruit_grapes 1 i_ham 1 i_cheese_cut 1 i_muffins 1 i_fish_cut_cooked 1 i_ribs_cooked 1 i_bird_cooked 1 i_sausages 1 i_fruit_apple 1 i_fruit_peach 1}
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
27-08-13 20:57CorujaNew Issue
16-10-13 02:45RanXeroxAssigned To => RanXerox
16-10-13 02:45RanXeroxStatusnew => assigned
01-12-13 09:48khaosNote Added: 0001793
01-12-13 09:50khaosNote Added: 0001794
01-12-13 09:50khaosStatusassigned => closed
01-12-13 09:50khaosResolutionopen => no change required
01-12-13 22:31RanXeroxNote Added: 0001796
01-12-13 22:31RanXeroxStatusclosed => feedback
01-12-13 22:31RanXeroxResolutionno change required => reopened
01-12-13 22:31RanXeroxStatusfeedback => assigned
15-10-14 03:30BenNote Added: 0002477
15-10-14 03:30BenStatusassigned => resolved
15-10-14 03:30BenFixed in Version => 0.56c Nightly
15-10-14 03:30BenResolutionreopened => fixed
15-10-14 03:30BenAssigned ToRanXerox => Coruja

Notes
(0001793)
khaos   
01-12-13 09:48   
This can be soft coded and does not require any form of hard code update. You provided the exact use above. Sphere is not EA. We provide EA support via soft code and internal hard code where needed. We are not going to switch the entire internals of the Hard Code to perpetuate a complete EA clone.

Again, you provided a script. If you wanted you can send contributions such as this to me, Ran, Ben, or XuN. I am in the process of helping Ran get the Base packs in order. I am also going to prepare two sets of equipment and possibly spell codes for use (UO:R Damage style and AoS Damage style).

Ran should have closed this out. Again, we are not EA. Please contribute to the AoS Basepack (No dev overwrite the old spells please unless needed and please don't alter things in the hard code that can be done as they are above in the soft code).
(0001794)
khaos   
01-12-13 09:50   
I attached a note to this already on the reason I am CLOSING THIS. Ran Xerox if you are seeing this; please note the changes in spare rar file. Coruja used to do a lot for the community; but as your own argument is: We are not EA. Please leave the old spell code for this alone.
(0001796)
RanXerox   
01-12-13 22:31   
For what its worth, I took this ticket not to blindly implement it verbatim as Khaos seems to assume.

For example, it makes sense that if no SPELLFLAG_TARG* was specified, the default behavior should automatically create the food in the pack. Also, if indeed the sound does not always play, that does imply some other logic flaw in the hardcode behavior.
(0002477)
Ben   
15-10-14 03:30   
You should close the tickets you fixed :P
Specially if you're the reporter...