SphereServer BugTracker - SphereServer
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002239SphereServerexecutable - windows buildpublic11-11-13 15:3721-12-13 22:52
ReporterCoruja 
Assigned ToBen 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version0.56c Nightly 
Nightly VersionAutomated (specify build number)
Experimental FlagsNone
Option FlagsNone
Internal Build Number
Summary0002239: EF_ItemStacking crashing sphereSvr.exe
DescriptionWhen I enable it, sphere simply crash on a few seconds without any error/exception on log.
I dont know how debug it to find the cause of the problem, but know that it's related to EF_ItemStacking because I startup the server without this setting, and then every time I enable it the server goes down in seconds. And if I launch already with EF_ItemStackiing enabled it wont last more than 1 minute online too

It crash randomly even without any player online, so I think it's something related to NPC trying to pick/drop items (it occours no matter NPC_AI_MOVEOBSTACLES is enabled/disabled)
Or it can be something related to a item decaying, making a stack pile goes down and returning a error
Steps To Reproduce
Additional Information// Experimental flags
// Flags for options that affect server behaviour and which might affect compatibility
// See the revisions.txt file for more details on this
// EF_DiagonalWalkCheck = 00000001
// EF_FixKillTrigger = 00000002
// EF_ItemStacking = 00000004
// EF_Intrinsic_Locals = 00000020
// EF_Item_Strict_Comparison = 00000040
// EF_NewPositionChecks = 00000080 // Do not set while server is running !!!
// EF_WalkCheck = 00000100
// EF_AllowTelnetPacketFilter = 00000200 // Enables packet filtering for telnet connections as well
// EF_Script_Profiler = 00000400
// EF_Size_Optimise = 00000800
// EF_DamageTools = 00002000 // damage tools (and fire @damage on them) while mining or lumberjacking
// EF_PetSlots = 00004000 // INCOMPLETE YET! DO NOT USE until this warning is removed!
// EF_UsePingServer = 00008000 // Enable the experimental Ping Server (for showing pings on the server list, uses UDP port 12000)
// EF_FixCanSeeInClosedConts = 00020000 // Change CANSEE to return 0 for items inside containers that a client hasn't opened
// EF_Specific = 01000000 // Specific behaviour, not completly tested
Experimental=00000001|00000002|00000004|00000080|00000100|00008000

// Option flags
// Flags for options that affect server behaviour but not compatibility
// See the revisions.txt file for more details on this
// OF_Command_Sysmsgs = 00000008 //Shows status of hearall, allshow, allmove... commands after toggling them
// OF_OSIMultiSight = 00000020
// OF_Items_AutoName = 00000040
// OF_FileCommands = 00000080
// OF_NoItemNaming = 00000100
// OF_NoHouseMuteSpeech = 00000200
// OF_Flood_Protection = 00001000
// OF_Buffs = 00002000
// OF_NoPrefix = 00004000 // Add prefix "A" and "An" to itemnames or not
// OF_DyeType = 00008000 // if set allows using i_dye on all t_dye_vat instead of only i_dye_tub
// OF_DrinkIsFood = 00010000 // type T_DRINK will increase FOOD lvl like T_FOOD
// OF_DClickNoTurn = 00020000 // the player won't turn when dclick or targ an item
// OF_Specific = 01000000 // Specific behaviour, not completly tested
OptionFlags=00000008|00000020|00000080|00000100|00000200|00002000|00004000|00008000

// NPC AI settings
// NPC_AI_PATH 0001 NPC pathfinding
// NPC_AI_FOOD 0002 NPC food search (objects + grass)
// NPC_AI_EXTRA 0004 NPC magics, etc
// NPC_AI_ALWAYSINT 0008 Always be as smart as possible with pathfinding
// NPC_AI_INTFOOD 0010 NPC food search (more intelligent and trusworthy)
// NPC_AI_COMBAT 0040 Look for friends in combat
// NPC_AI_VEND_TIME 0080 vendors closing their shops at nighttime
// NPC_AI_LOOTING 0100 loot corpses an the way
// NPC_AI_MOVEOBSTACLES 0200 if moveable items block my way, try to move them
// NPC_AI_PERSISTENTPATH 0400 NPC will try often to find a path with pathfinding
NPCAI=0004|0008|0200
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
11-11-13 15:37CorujaNew Issue
12-11-13 03:10BenNote Added: 0001774
12-11-13 03:14BenNote Edited: 0001774bug_revision_view_page.php?bugnote_id=0001774#r540
13-11-13 03:37CorujaNote Added: 0001775
13-11-13 03:38CorujaNote Edited: 0001775bug_revision_view_page.php?bugnote_id=0001775#r542
23-11-13 17:51DavideReiNote Added: 0001780
29-11-13 18:04CorujaNote Added: 0001785
15-12-13 15:01BenNote Added: 0001850
16-12-13 00:36CorujaNote Added: 0001855
16-12-13 04:24CorujaNote Added: 0001859
21-12-13 22:52BenNote Added: 0001865
21-12-13 22:52BenStatusnew => resolved
21-12-13 22:52BenFixed in Version => 0.56c Nightly
21-12-13 22:52BenResolutionopen => fixed
21-12-13 22:52BenAssigned To => Ben

Notes
(0001774)
Ben   
12-11-13 03:10   
(edited on: 12-11-13 03:14)
I Split EF_ItemStacking into 2 setting.
EF_ItemStackDrop 0x08 will take care of the item dropping part.
Can you let me know which part is causing it since I don't have a populated shard to test this with.

Also, Item decay doesn't seem to be the problem (decay doesn't trigger item fall)
(0001775)
Coruja   
13-11-13 03:37   
(edited on: 13-11-13 03:38)
I tested here both EF_ItemStacking and EF_ItemStackDrop

EF_ItemStackDrop works fine, but if I enable EF_ItemStacking the server crash after some seconds without any player connected
(0001780)
DavideRei   
23-11-13 17:51   
I confirm this issue.
No problem with EF_ItemStackDrop.
With EF_ItemStacking enabled sometimes sphere crashes when i drop an item onto a static item.
Happen to me every time i drop a door(i_door_wood_3) onto a static wall(i_wall_stone_sm_4).
And every time i drop a worldgem bit onto a static carpet(0ad1).
(0001785)
Coruja   
29-11-13 18:04   
On newest builds (after EF_ITemStackDrop last change) the server doesnt crash without player anymore, but it keep crashing with players, probably when someone pick or drop an item. The server always goes down in 5 minutes after launch, much better than before but it still crashing :D

If you want, I think its a good idea create a new EF_ItemStackDebug temporary flag to debug everything on the console and make it easier to fix
(0001850)
Ben   
15-12-13 15:01   
Any more news on this? I have removed the code that disabled item flipping on drop a few days ago but got no feedback yet.
(0001855)
Coruja   
16-12-13 00:36   
I will test it again in a few minutes
(0001859)
Coruja   
16-12-13 04:24   
items are flipping again when stacked, but at least the server seems to be stable for now (2hr uptime without any crash)
(0001865)
Ben   
21-12-13 22:52   
Alright, closing this.