SphereServer BugTracker - SphereServer
View Issue Details
0002260SphereServerexecutable - windows buildpublic11-01-14 01:0215-01-14 00:35
Coruja 
XuN 
normalminoralways
resolvedfixed 
 
 
Automated (specify build number)
None
None
0002260: Trade Window problems on 11 jan build
Using 11 jan build, I noticed some problems on trade window after these latest changes

IMG 1) Using TradeWindowSnooping=0, if I put a metal chest with a bag inside containing a item (metal chest > bag > item) on the trade, I can freely pick or drop any item inside the bag

IMG 2) Same problem above but now viewing as the other char. I can open the metal chest, but not the bag inside this metal chest

bug 3) Everytime someone accept/cancel a trade it will show a sysmessage 'TradeCancel' (maybe someone forgot to disable these debugs msgs) :P
No tags attached.
png tradewindowbug.png (296,410) 11-01-14 01:02
http://tracker.sphere.torfo.org/bugs/file_download.php?file_id=89&type=bug
Issue History
11-01-14 01:02CorujaNew Issue
11-01-14 01:02CorujaFile Added: tradewindowbug.png
11-01-14 01:13CorujaNote Added: 0001893
11-01-14 16:12XuNNote Added: 0001895
11-01-14 16:12XuNAssigned To => XuN
11-01-14 16:12XuNStatusnew => assigned
12-01-14 00:16XuNNote Added: 0001896
12-01-14 00:16XuNStatusassigned => resolved
12-01-14 00:16XuNResolutionopen => fixed
14-01-14 20:55CorujaNote Added: 0001907
14-01-14 20:55CorujaStatusresolved => feedback
14-01-14 20:55CorujaResolutionfixed => reopened
15-01-14 00:35XuNNote Added: 0001909
15-01-14 00:35XuNStatusfeedback => resolved
15-01-14 00:35XuNResolutionreopened => fixed

Notes
(0001893)
Coruja   
11-01-14 01:13   
also @TradeDelete on chars is not working, I dont know if there's a bug or if I'm doing something wrong. I tried this event, but nothing occours when I cancel the trade (mouse right click on trade window)

[EVENTS e_lol]
ON=@TradeDelete
SERV.B debug lol
(0001895)
XuN   
11-01-14 16:12   
I'm looking for the problem moving items inside containers, and for the close... it is @TradeClose, it was @tradeDelete before but @TradeClose fits better and forgot to update this on notes.
(0001896)
XuN   
12-01-14 00:16   
Fixed
(0001907)
Coruja   
14-01-14 20:55   
thx :D
everything is almost fixed now, you just forgot the pick/drop issue. Using the same example above (metal chest > bag > katana), the 'trade owner' can pick/drop itens on the bag inside the metal chest

even picking or dropping itens inside the bag, the container got updated to the other player. But allow pick/drop items could take serious problems if used by a noob which can maliciously remove all items inside the bag 1 second before accept the trade
(0001909)
XuN   
15-01-14 00:35   
I created the function but did not add to all places I should, fixed now.