SphereServer BugTracker - SphereServer
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002262SphereServerexecutable - windows buildpublic14-01-14 21:2916-01-14 15:56
ReporterCoruja 
Assigned ToXuN 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Nightly VersionAutomated (specify build number)
Experimental FlagsNone
Option FlagsNone
Internal Build Number
Summary0002262: f_onchar_create can't read the char name anymore
DescriptionOn last nightly (14 jan) the function f_onchar_create can't get the char name anymore

// This function is called after client created a new char.
// SRC --> char being created
// ARGN1 --> flags
// ARGN2 --> profession chosen
// ARGN3 --> race (1=human, 2=elf, 3=gargoyle)
// ARGS --> account name
// ARGO --> the client creating the character
// RETURN
// 0 --> normal action (create character)
// 1 --> denyes creation
[FUNCTION f_onchar_create]
SERV.LOG Char name: <SRC.NAME> / UID: <SRC>


this will return the SRC without problems, but the char name <SRC.NAME> will always be 'Man'. The correct behavior is return the name choosed on character creation menu

this could take some serious problems on shards which check all these names to prevent accounts choose duplicated char names :P
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
14-01-14 21:29CorujaNew Issue
15-01-14 00:20XuNNote Added: 0001908
15-01-14 00:20XuNStatusnew => resolved
15-01-14 00:20XuNResolutionopen => fixed
15-01-14 00:20XuNAssigned To => XuN
16-01-14 07:32CorujaNote Added: 0001911
16-01-14 07:32CorujaStatusresolved => feedback
16-01-14 07:32CorujaResolutionfixed => reopened
16-01-14 15:55XuNNote Added: 0001912
16-01-14 15:56XuNStatusfeedback => resolved
16-01-14 15:56XuNResolutionreopened => fixed

Notes
(0001908)
XuN   
15-01-14 00:20   
Fixed, all character data is being read before the function now.
(0001911)
Coruja   
16-01-14 07:32   
lol maybe this change broke the return 1 on f_onchar_create :P
return 1 disconnect and block the client to enter the game using the created char, but sphere doesnt really deny the char creation. After disconnect, if the client try to use the account again the char will be already created and ready to use
(0001912)
XuN   
16-01-14 15:55   
Char is now deleted if creation is blocked.