SphereServer BugTracker - SphereServer
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002274SphereServerexecutable - windows buildpublic03-02-14 00:4406-02-14 19:23
ReporterCoruja 
Assigned ToXuN 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Nightly VersionAutomated (specify build number)
Experimental FlagsNone
Option FlagsNone
Internal Build Number
Summary0002274: NPCs vendors revealing invisible GM accounts near
DescriptionOn npc vendors, the msg 'npc_generic_interrupt' (from sphere_msgs.scp) is revealing invisible GM members near the npc

I mean, the player is talking (buy/sell/train/etc) to a npc, then I come near this same npc with my invisible GM account and the npc will say "Sorry xxxxx, but Coruja wanna talk with me". It will not remove the invisible flag, but the player will know that someone is there

Maybe a great way to fix this is use a simple CANSEE to make the npc say this message only to visible chars
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
03-02-14 00:44CorujaNew Issue
05-02-14 15:39XuNNote Added: 0001940
05-02-14 15:39XuNAssigned To => XuN
05-02-14 15:39XuNStatusnew => feedback
06-02-14 00:17CorujaNote Added: 0001942
06-02-14 00:17CorujaStatusfeedback => assigned
06-02-14 19:23XuNNote Added: 0001943
06-02-14 19:23XuNStatusassigned => resolved
06-02-14 19:23XuNResolutionopen => fixed

Notes
(0001940)
XuN   
05-02-14 15:39   
I can't reproduce this, and the code is not revealing any issue related either... this text is called on NPC_OnHear() wich is called when you say anything and this npc hears it.
(0001942)
Coruja   
06-02-14 00:17   
probably there's the mistery, I tried on my custom vendor, which open a dialog and the dialog button uses "HEAR something" to call others

[EVENTS e_custom_vendor] //event running on vendor
ON=@DClick
FACE <SRC>
...
SDIALOG d_vendor

[DIALOG d_vendor button]
ON=0
FACE <SRC>
BOW

ON=1
HEAR browse

ON=2
HEAR collect

ON=3
...


So now I dont know if it's really a bug, I already fixed removing this msg from sphere_msgs. But it would be great a simple 'cansee' check because it doesn't makes sense if someone say "Sorry but I must talk to xxx" if this player xxx cant seen by anyone. Even really using a spoken command (onhear) the player can use hidding/invisibility or just run away :D
(0001943)
XuN   
06-02-14 19:23   
It's not a bug, there is already a Cansee() check in the code so the npcs don't interact with invisible characters, however if I block it in the OnHear() inside code you couldn't make them use hear xxx while invisible, so I think it should be up to you block it or not with a simple if !(<statf>&statf_invisible).