SphereServer BugTracker - SphereServer
View Issue Details
0002573SphereServerexecutable - windows buildpublic02-02-16 09:3928-02-16 23:03
darksun84 
Coruja 
normalcrashalways
resolvedfixed 
 
0.56c Nightly 
Automated (specify build number)
None
None
2674
0002573: Recent changes about custom skill and error messages in console
Recently, when you try to add a new skill in a new slot (Example at slot 58)
you'll get an error message when using the command for setting/displaying the skill value

Example:

[SKILL 58]
DEFNAME=SKILL_Melee
KEY=Melee
TITLE=Fighter
FLAGS=SKF_FIGHT
STAT_STR=40
STAT_INT=30
STAT_DEX=70
BONUS_STR=0
BONUS_DEX=95
BONUS_INT=5
BONUS_STATS=10
ADV_RATE=10.0,200.0,800.0

The first time we do .show melee we will get a super high value but no error
If we try to set the melee skill, we will get an error message like this:

:28:DEBUG:__ thread (1940) __ | # | _____ function _____________ | ticks passed from previous function start ______
09:28:DEBUG:>> 1940 | 0 | NetworkManager::processAllInput | +0
09:28:DEBUG:>> 1940 | 1 | NetworkInput::processInput | +0
09:28:DEBUG:>> 1940 | 2 | NetworkInput::processData | +0
09:28:DEBUG:>> 1940 | 3 | NetworkInput::processData | +0
09:28:DEBUG:>> 1940 | 4 | NetworkInput::processGameClientData | +0 <-- exception catch point (below is guessed and could be incorrect!)
09:28:DEBUG:>> 1940 | 5 | PacketSpeakReqUNICODE::onReceive | +0
09:28:DEBUG:>> 1940 | 6 | CClient::Event_TalkUNICODE | +0
09:28:DEBUG:>> 1940 | 7 | CClient::Event_Command | +0
09:28:DEBUG:>> 1940 | 8 | CGFile::Close | +0
09:28:CRITICAL:"Access Violation" (0xfff525bd), in SUB: NetworkInput::Message::ProcessMessage()
09:28:DEBUG:1:Parsing Packet len=34 id=0xad [2016/02/02 09:28:55]
        0 1 2 3 4 5 6 7 8 9 A B C D E F
       -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
0000 ad 00 22 00 00 34 00 03 49 54 41 00 00 2e 00 6d .."..4..ITA....m
0010 00 65 00 6c 00 65 00 65 00 20 00 33 00 30 00 30 .e.l.e.e. .3.0.0
0020 00 00 ..


If then we do again .show melee another similar error will be thrown on the console.

Lastly, if player performs a log out, it will not be able to log in the game anymore until the new skill is removed from sphere_skills.scp.
(Player can actually create a new character but it crash)

Custom skills were working fine, so i think that is related to the recent skills change (see: https://github.com/Sphereserver/Source/commit/988c97667338462c22009429554ebe35b1394baa [^] )



Add a new skill
Set the new skill
Display the new skill by using .show
Logout from the game
Try to login again with the same character or create a new one, you will not be able to log.
No tags attached.
Issue History
02-02-16 09:39darksun84New Issue
06-02-16 12:54nolokNote Added: 0003007
08-02-16 18:55darksun84Note Added: 0003008
28-02-16 23:03CorujaNote Added: 0003012
28-02-16 23:03CorujaStatusnew => resolved
28-02-16 23:03CorujaFixed in Version => 0.56c Nightly
28-02-16 23:03CorujaResolutionopen => fixed
28-02-16 23:03CorujaAssigned To => Coruja

Notes
(0003007)
nolok   
06-02-16 12:54   
Fixed in recent nightlies :D
(0003008)
darksun84   
08-02-16 18:55   
Yes, looks fixed. Thank you
(0003012)
Coruja   
28-02-16 23:03   
I don't know who fixed this, but anyway if ppl said that its fixed I'll mark this issue as fixed :P