SphereServer BugTracker - SphereServer
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001597SphereServerexecutable - genericpublic03-05-09 06:0804-05-09 23:43
Reportercloud_br 
Assigned ToMrSugarCube 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version20-09-2009, 0.56b Prerelease 
Nightly VersionNot Available
Experimental FlagsDiagonalWalkCheck, Unicode, New_Triggers, Item_Strict_Comparison, NewPositionChecks, AllowTelnetPacketFilter, Size_Optimise, DamageTools, UsePingServer, UseNetworkMulti
Option FlagsCommand_Sysmsgs, OSIMultiSight, FileCommands, NoHouseMuteSpeech, Buffs, NoPrefix, DyeType
Internal Build Number
Summary0001597: Bug in char/item seeing in last nightly (03/05/09)
DescriptionSome chars and items don't get sent to the client after the new update that was supposed to fix items that are able to be seen in the client screen but returned CANSEE as 0.
That fix:
02-05-2009, MrSugarCube
- Fixed 0001581: Characters unable to see objects that are in the corners of their visual range.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
03-05-09 06:08cloud_brNew Issue
03-05-09 06:08cloud_brNightly Version => Not Available
03-05-09 06:08cloud_brExperimental Flags => DiagonalWalkCheck, Unicode, New_Triggers, Item_Strict_Comparison, NewPositionChecks, AllowTelnetPacketFilter, Size_Optimise, DamageTools, UsePingServer, UseNetworkMulti
03-05-09 06:08cloud_brOption Flags => Command_Sysmsgs, OSIMultiSight, FileCommands, NoHouseMuteSpeech, Buffs, NoPrefix, DyeType
03-05-09 06:09cloud_brNote Added: 0000201
04-05-09 03:58cloud_brNote Added: 0000203
04-05-09 04:54MrSugarCubeNote Added: 0000204
04-05-09 04:54MrSugarCubeAssigned To => MrSugarCube
04-05-09 04:54MrSugarCubeStatusnew => feedback
04-05-09 05:08cloud_brNote Added: 0000205
04-05-09 05:09cloud_brNote Edited: 0000205
04-05-09 05:10cloud_brNote Added: 0000206
04-05-09 05:23MrSugarCubeNote Added: 0000207
04-05-09 05:28MrSugarCubeNote Edited: 0000207
04-05-09 05:34cloud_brNote Added: 0000208
04-05-09 05:35cloud_brNote Edited: 0000208
04-05-09 05:37cloud_brNote Edited: 0000208
04-05-09 05:44cloud_brNote Added: 0000209
04-05-09 06:57MrSugarCubeNote Added: 0000210
04-05-09 21:21cloud_brNote Added: 0000211
04-05-09 23:32cloud_brIssue Monitored: cloud_br
04-05-09 23:32cloud_brIssue End Monitor: cloud_br
04-05-09 23:40MrSugarCubeBuild => 1127
04-05-09 23:43MrSugarCubeStatusfeedback => resolved
04-05-09 23:43MrSugarCubeFixed in Version => 0.56c Nightly
04-05-09 23:43MrSugarCubeResolutionopen => fixed
04-05-09 23:43MrSugarCubeNote Added: 0000212

Notes
(0000201)
cloud_br   
03-05-09 06:09   
Forgot to say:
Client version is 6.0.13
(0000203)
cloud_br   
04-05-09 03:58   
Note:
About
02-05-2009, MrSugarCube
- Fixed 0001581: Characters unable to see objects that are in the corners of their visual range.

Wasn't it enough to just increase the distance to consider CANSEE and CANSEELOS true? o.O
(0000204)
MrSugarCube   
04-05-09 04:54   
Nope. :)

Can you retest on the latest automated build? (May 4th)

I couldn't reproduce the problem but found a possible cause relating to the OSIMultiSight flag, so if the issue is still present on the latest build then it would be useful to see if the problem still exists with this flag disabled.
(0000205)
cloud_br   
04-05-09 05:08   
(edited on: 04-05-09 05:09)
Tested without OSI_Multisight and it was still bugged
Tested without OSI_Multisight and NewPositionCheck and it was still bugged.
Tested with AdvancedLOS on for npcs and players, with OSI_Multisight and Newposition Checks off and it was still bugged.
Tested without DiagonalWalkCheck (just in case =P) and it was still bugged.
Tested with all experimental and optionflags off and it was still bugged.

I used:
Download latest Windows build (May 4, 2009, 12:00 am)

But I have to say it is older then the linux one AND if I remember well the latest change to revisions.txt wasn't there, so maybe it isn't actually the most up-to-date exe?
That change:
03-05-2009, MrSugarCube
- Fixed 0001526: No decay timer set on lights after they become unlit.

I reverted back to 29 April build and no problems.
(0000206)
cloud_br   
04-05-09 05:10   
Oh, and I was looking at Luna - Malas
(0000207)
MrSugarCube   
04-05-09 05:23   
(edited on: 04-05-09 05:28)
Do you have .allshow on, and if so does switching it off solve the problem? (flag 04000 on account.priv)
(0000208)
cloud_br   
04-05-09 05:34   
(edited on: 04-05-09 05:37)
I don't have allshow on, I tested with a player account.
ACCOUNT.RESDISP=5
But it also happened with a gm account without allshow on.

MrSugarCube, to make sure, walk a little because SOME npcs get sent, and others simply don't.

Two pics, one before .update and the other after:
http://img15.imageshack.us/img15/5345/teste1bei.jpg [^]
http://img5.imageshack.us/img5/2458/teste2sua.jpg [^]

I tried finding a pattern for the npcs that appear and the ones that don't, but so far unsuccsesful

that blue text on the left down corner is the text said by the Town Crier

and to correct: it seems to be happening only with mobiles, not items
(0000209)
cloud_br   
04-05-09 05:44   
MrSugarCube:
As I said, I think the currently available windows build isn't the most up-to-date one.
I saw on the changelog you made this change:
MrSugarCube r1127 03.05.09

0001581: Missed a GetDist()->GetDistSight() change in CClient::addPlayerSee.

On 03/05/2009, but look at the compilation date of the current windows exe:
Sphere Version 0.56b-Nightly [WIN32] by www.sphereserver.com, compiled at May 2 2009 (21:09:40)

02/05/2009

So I guess your fix might not have been added yet, perhaps tomorrow?
(0000210)
MrSugarCube   
04-05-09 06:57   
I've been able to reproduce the problem and now believe that it is fixed. Hopefully tomorrow's automated build will contain the changes so that you can confirm it. :)

The compilation date may not update depending on how Torfo has set up the build environment, but as long as the revisions file inside the zip has been updated then I would expect the build to have reflected the changes (there has been an entry added for 04-05-2009).
(0000211)
cloud_br   
04-05-09 21:21   
Looks fixed =]
(0000212)
MrSugarCube   
04-05-09 23:43   
I'll consider it fixed then, thanks. :)