0002149: Saving Stactics with SaveBackground option on (set to 1) makes statics save loop indefinetly

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002149

SphereServer

executable - generic

public

20-03-13 02:26

24-03-13 18:07

Reporter

ErebusDragon

Assigned To

Ben

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

no change required

Platform

PC (Desktop)

Windows

OS Version

Seven

Product Version

20-09-2009, 0.56b Prerelease

Target Version

Fixed in Version

Summary

0002149: Saving Stactics with SaveBackground option on (set to 1) makes statics save loop indefinetly

Description

I've started my server and made some changes that I wished to save.
I've executed ".save" from in-game as owner and the statics save started to loop!
So I've tryed to execute from the console, just to try it out, and the result was the same (It seemed obvious, but it's always nice to try xD)
Even restarting the server, to make sure it wasn't a resync issue, the problem continues!

Can't tell for sure the version I'm using, cause I've just installed the vSphereLauncher. Checking in the application info I found:
Version = 0.56.2.0
Last Update = 02/19/2013 00:07

Steps To Reproduce

1 - Set "SaveBackground=0"
2 - Save (in-game command or console command "save")
3 - Check that it saves normally

4 - Set "SaveBackground=1"
5 - Save (as in step 2)
6 - Check the indefinetly loop

Additional Information

I select "None" for flags, since I just runned vSphereLauncher and it has some flags set as default! But I think it won't make any diference!

One last thing, I've oppened "sphere_serv_trigger" to check for the cause, and it seems to be the following lines:

/////////////////////////////////////////////////////////////////

// This function is called before server is going to save.
// ARGN1 --> save is forced (writable)
// ARGN2 --> save stage (for backgroud save goes 1 to 6146 [sector count + 2])
// RETURN
// 0 --> normal action (save)
// 1 --> denyes save
[FUNCTION f_onserver_save]
serv.savestatics

/////////////////////////////////////////////////////////////////

It seems to be the ARGN2 that will be saving an huge amount of static sectors or something :/

Tags

No tags attached.

Nightly Version

Automated (specify build number)

Experimental Flags

None

Option Flags

None

Internal Build Number

Attached Files

Relationships

Notes
(0001500) Shaklaban (developer) 20-03-13 10:21 edited on: 20-03-13 10:22	background save saving sectors one by by. so this is a intended behaviour. you need to check argn2, example: [FUNCTION f_onserver_save] if (<argn2> = 1) serv.savestatics endif or save statics under save finished trigger: [FUNCTION f_onserver_save_finished] serv.savestatics

(0001501) ErebusDragon (reporter) 20-03-13 12:38	Shaklaban, I got that from: // ARGN2 --> save stage (for backgroud save goes 1 to 6146 [sector count + 2]) but it should come as you told me to do without the need to change by hand. I imagine someone trying to run his new saves in background and get that 6146 saving messagem in all clients! What a major lag that would cause! Just fixing it in the Nightly Releases would enough ;)

(0001520) Ben (manager) 24-03-13 18:07	Having serv.savestatics in this trigger is not part of the default script pack, so there is nothing to fix here for sphere. Your problem is with the SCP. Report your problem on the forum in the SCP section.

Issue History
Date Modified	Username	Field	Change
20-03-13 02:26	ErebusDragon	New Issue
20-03-13 10:21	Shaklaban	Note Added: 0001500
20-03-13 10:22	Shaklaban	Note Edited: 0001500	View Revisions
20-03-13 12:38	ErebusDragon	Note Added: 0001501
24-03-13 18:07	Ben	Note Added: 0001520
24-03-13 18:07	Ben	Status	new => closed
24-03-13 18:07	Ben	Assigned To	=> Ben
24-03-13 18:07	Ben	Resolution	open => no change required