Main | My View | View Issues | Change Log | Roadmap
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001850SphereServernew feature requestpublic05-11-10 06:0504-11-15 19:46
ReporterCoruja 
Assigned ToCoruja 
PrioritynormalSeverityminorReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version0.56c Nightly 
Summary0001850: brain_banker + brain_vendor
DescriptionActually if you set NPC=brain_banker on a npc, it will act like a banker, and NPC=brain_vendor will act like a vendor

On OSI bankers act like vendors (to buy/sell items), but there's no way to do this on sphere. So my request is do something to allow brain_banker act like brain_vendor too :D
TagsNo tags attached.
Nightly VersionNot Available
Experimental FlagsNone
Option FlagsNone
Internal Build Number
Attached Files

- Relationships

-  Notes
(0002139)
Feeh (developer)
02-05-14 18:24

 Isn't it handled by TSPEECH=jobbanker ?
(0002140)
Coruja (developer)
02-05-14 19:24

 Nice, if I add TSPEECH=jobbanker on a vendor (NPC=brain_vendor) it will work fine and I can use bank + buy/sell items

but if I add TSPEECH=spk_shopkeep on the banker (NPC=brain_banker) and set BUY/SELL list it will work as banker but it will say "I have nothing to buy/sell"

whats the difference between brain_vendor and brain_banker? If brain_banker doesnt have nothing special I think it fine replace it by brain_vendor and add bank functionality using TSPEECH=jobbanker
(0002141)
XuN (developer)
03-05-14 09:51

 Right now it doesn't matter you have brain_banker or brain_berserk, the hear command 'bank' will do src.bankself ... so this is why bank will open, however it was mean to be open only on bankers, hence the brain.

Vendors can manage your bank, bankers cannot sell their items: solution ... add vendors with bank.
(0002148)
Feeh (developer)
04-05-14 17:49
edited on: 04-05-14 17:53

 Brain Banker is used internally to:
1- place the Bank context menu option
2- Gold dropped to the banker will be moved into player's account
3- // NPC's with special key words ?

My first solution: I've created a third mix of banker+vendor, so the npc will display both banker and vendor context menus and will allow players to buy from it

My second solution: Set the banker as vendor in the CCharNPC::IsVendor() function. This alone will not place the banker context menu but may allow player to buy from it. Context menus check may use the IsVendor function

My third solution: mix both vendor and banker into one brain, check for IsVendor/Context menus/etc by the existence of vendor boxes and open bank inside the core instead of scripts

Coruja's solution: Town NPC's will always be human (NPCBRAIN_HUMAN -> 2) and create both CAN flags mt_BANKER and mt_VENDOR. context menus will use the can flag to display its respective items

Mu fourth solution: Brain act like flags instead of numbers. Major core mods needed

I've done my first solution, it is working well but it does create a new npc brain only to supply such feature, that's why I didn't committed yet

- Issue History
Date Modified Username Field Change
05-11-10 06:05 Coruja New Issue
02-05-14 18:24 Feeh Note Added: 0002139
02-05-14 19:24 Coruja Note Added: 0002140
02-05-14 20:23 Feeh Assigned To => Feeh
02-05-14 20:23 Feeh Status new => assigned
03-05-14 09:51 XuN Note Added: 0002141
04-05-14 17:49 Feeh Note Added: 0002148
04-05-14 17:52 Feeh Note Edited: 0002148 View Revisions
04-05-14 17:53 Feeh Note Edited: 0002148 View Revisions
23-05-14 20:21 Feeh Assigned To Feeh =>
29-10-14 11:44 XuN Assigned To => Coruja
04-11-15 19:46 Coruja Status assigned => resolved
04-11-15 19:46 Coruja Fixed in Version => 0.56c Nightly
04-11-15 19:46 Coruja Resolution open => fixed

Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker