0002223: TAG inherit on shrink - SphereServer BugTracker

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002223

SphereServer

new feature request

public

19-10-13 01:35

19-10-13 05:04

Reporter

Coruja

Assigned To

Ben

Priority

normal

Severity

minor

Reproducibility

N/A

Status

closed

Resolution

no change required

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0002223: TAG inherit on shrink

Description

On latest nightly I saw something about shrink on changelog and I had a new idea: make the SHRINK function inherit TAGS from the pet.

It will create the NPC icon with the same tags from the NPC, and when dclick on t_figurine, the created NPC will inherit it again

Additional Information

this would be usefull for ppl like me which needs a huge workaround just to inherit simple tags, like this:

[FUNCTION lol]
...
CALL f_shrink
NEW.CONT=<SRC.FINDLAYER.21>
...

[FUNCTION Shrink2]
SERV.NEWITEM <ICON>
NEW.COLOR=<COLOR>
NEW.NAME=<NAME>
NEW.MORE1=<BASEID>
NEW.TYPE=t_figurine
NEW.TAG.Barding.Points=<TAG.Barding.Points>
NEW.TAG.Barding.Exceptional=<TAG.Barding.Exceptional>
NEW.P=

NEW.UPDATE
REMOVE

[TYPEDEF t_figurine]
ON=@DClick
IF (<TOPOBJ> != <SRC>)
SRC.SYSMESSAGE @,,1 The item must be with you.
return 1
ELIF (<SERV.MountHeight>)
SRC.HEIGHT=<DEF0.height_<HVAL <MORE>>>
IF !(<SRC.ISVERTICALSPACE>)
  SRC.SYSMESSAGE @,,1 The creature is too tall to fit this location.
  SRC.HEIGHT=
  return 1
ENDIF
SRC.HEIGHT=
ENDIF
SERV.NEWNPC <QVAL (<MORE>)? <HVAL <MORE>>:<TDATA3>>
REF1=<NEW>
SERV.NEWITEM i_memory
NEW.COLOR 02
NEW.LINK=<SRC>
NEW.CONT=<REF1>
REF1.TAG.Barding.Points=<TAG.Barding.Points>
REF1.TAG.Barding.Exceptional=<TAG.Barding.Exceptional>
REF1.NAME=<NAME>
REF1.COLOR=<COLOR>
REF1.P=<SRC.P>
REF1.UPDATE
REMOVE
return 1

Using inherit tags, this huge code will be reduced to just 2 lines:

[FUNCTION lol]
...
SHRINK
ACT.CONT=<SRC.FINDLAYER.21>
...

Tags

No tags attached.

Nightly Version

Not Available

Experimental Flags

None

Option Flags

None

Internal Build Number

Attached Files

Relationships

Notes
(0001736) Ben (manager) 19-10-13 01:47	I don't see the point here... With default shrink, the pet is not removed so it keeps it's tags when unshrunk.

(0001738) Coruja (developer) 19-10-13 04:04	roflmao, I never noticed this, maybe it's because I'm already using my shrink workaround for ages So I think its better continue using my workaround, it's a bad idea transform 90.000 items (shrinked mounts) into 90.000 items + 90.000 offline NPCs :(

Issue History
Date Modified	Username	Field	Change
19-10-13 01:35	Coruja	New Issue
19-10-13 01:47	Ben	Note Added: 0001736
19-10-13 04:04	Coruja	Note Added: 0001738
19-10-13 05:04	Ben	Status	new => closed
19-10-13 05:04	Ben	Assigned To	=> Ben
19-10-13 05:04	Ben	Resolution	open => no change required