0002204: Cooking and Cartography not working properly as craft skills

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002204

SphereServer

executable - windows build

public

06-09-13 20:02

08-09-13 20:55

Reporter

Coruja

Assigned To

RanXerox

Priority

normal

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0002204: Cooking and Cartography not working properly as craft skills

Description

When the function MAKEITEM is used to craft items that uses COOKING as skillmake, the craft action doesnt even start. The char action continues ACTION=-1 and nothing occour.

And using on CARTOGRAPHY items, the craft action will start fine but on success the trigger @SkillMakeItem is not fired on the char

PS: Sphere default cartography skill uses "DRAWMAP xxx" instead of MAKEITEM. But here I'm trying to use MAKEITEM and then set a custom map X,Y area (MORE1 / MORE2) on @SkillMakeItem. The crafted item goes to my backpack without problems but the trigger @SkillMakeItem is not fired on the char

Steps To Reproduce

Just put resources on backpack and type .makeitem i_map_world / i_cake

Additional Information

Items used to reproduce the bug:

[ITEMDEF i_map_world]
ID=i_map
NAME=world map
RESOURCES=i_map_blank
SKILLMAKE=CARTOGRAPHY 50.0

[ITEMDEF 09e9]
DEFNAME=i_cake
TYPE=T_FOOD
RESOURCES=1 i_dough
SKILLMAKE=COOKING 0.1
WEIGHT=1.0
VALUE=10

-------------------------------

Skills on sphere_skills.scp

[SKILL 12]
DEFNAME=SKILL_CARTOGRAPHY
KEY=Cartography
TITLE=Cartographer
DELAY=2.0
STAT_STR=15
STAT_INT=70
STAT_DEX=20
BONUS_STR=0
BONUS_DEX=20
BONUS_INT=100
BONUS_STATS=15
ADV_RATE=5.0,10.0,20.0
VALUES=1,20,80

ON=@Fail
SRC.SYSMESSAGE Skill Cartography failed.

ON=@Abort
SRC.SYSMESSAGE Skill Cartography aborted.

[SKILL 13]
DEFNAME=Skill_Cooking
KEY=Cooking
TITLE=Chef
PROMPT_MSG=What would you like to cook?
DELAY=2.0
STAT_STR=25
STAT_INT=45
STAT_DEX=20
BONUS_STR=0
BONUS_DEX=40
BONUS_INT=60
BONUS_STATS=50
ADV_RATE=5.0,10.0,20.0
VALUES=1,20,80

Tags

No tags attached.

Nightly Version

Automated (specify build number)

Experimental Flags

None

Option Flags

None

Internal Build Number

Attached Files

Relationships

Notes
(0001653) Coruja (developer) 06-09-13 23:59 edited on: 07-09-13 00:48	I fixed cartography just adding FLAGS=skf_craft on [SKILL 12] and it's working fine now, all triggers is being called properly. But the problem on cooking remains :/ --------------------- EDIT: Strangely now adding FLAGS=skf_craft on cooking skill (13) fixed it too. Didn't work on first try but it's working now lol Everything got fixed just adding FLAGS=skf_craft on both skills. So it's not really a bug, the issue can be closed :D Btw, this solution is not documented on sphere_skills.scp, I think we must add a comment on [COMMENT SKILL x] about how to use FLAGS on skills

(0001664) RanXerox (developer) 08-09-13 20:55	Fixed today and will be in tomorrow's nightly build

Issue History
Date Modified	Username	Field	Change
06-09-13 20:02	Coruja	New Issue
06-09-13 23:59	Coruja	Note Added: 0001653
07-09-13 00:00	Coruja	Note Edited: 0001653	View Revisions
07-09-13 00:48	Coruja	Note Edited: 0001653	View Revisions
08-09-13 20:55	RanXerox	Note Added: 0001664
08-09-13 20:55	RanXerox	Status	new => resolved
08-09-13 20:55	RanXerox	Resolution	open => fixed
08-09-13 20:55	RanXerox	Assigned To	=> RanXerox