0002260: Trade Window problems on 11 jan build

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002260

SphereServer

executable - windows build

public

11-01-14 01:02

15-01-14 00:35

Reporter

Coruja

Assigned To

XuN

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0002260: Trade Window problems on 11 jan build

Description

Using 11 jan build, I noticed some problems on trade window after these latest changes

IMG 1) Using TradeWindowSnooping=0, if I put a metal chest with a bag inside containing a item (metal chest > bag > item) on the trade, I can freely pick or drop any item inside the bag

IMG 2) Same problem above but now viewing as the other char. I can open the metal chest, but not the bag inside this metal chest

bug 3) Everytime someone accept/cancel a trade it will show a sysmessage 'TradeCancel' (maybe someone forgot to disable these debugs msgs) :P

Tags

No tags attached.

Nightly Version

Automated (specify build number)

Experimental Flags

None

Option Flags

None

Internal Build Number

Attached Files

tradewindowbug.png [^] (296,410 bytes) 11-01-14 01:02

Relationships

Notes
(0001893) Coruja (developer) 11-01-14 01:13	also @TradeDelete on chars is not working, I dont know if there's a bug or if I'm doing something wrong. I tried this event, but nothing occours when I cancel the trade (mouse right click on trade window) [EVENTS e_lol] ON=@TradeDelete SERV.B debug lol

(0001895) XuN (developer) 11-01-14 16:12	I'm looking for the problem moving items inside containers, and for the close... it is @TradeClose, it was @tradeDelete before but @TradeClose fits better and forgot to update this on notes.

(0001896) XuN (developer) 12-01-14 00:16	Fixed

(0001907) Coruja (developer) 14-01-14 20:55	thx :D everything is almost fixed now, you just forgot the pick/drop issue. Using the same example above (metal chest > bag > katana), the 'trade owner' can pick/drop itens on the bag inside the metal chest even picking or dropping itens inside the bag, the container got updated to the other player. But allow pick/drop items could take serious problems if used by a noob which can maliciously remove all items inside the bag 1 second before accept the trade

(0001909) XuN (developer) 15-01-14 00:35	I created the function but did not add to all places I should, fixed now.

Issue History
Date Modified	Username	Field	Change
11-01-14 01:02	Coruja	New Issue
11-01-14 01:02	Coruja	File Added: tradewindowbug.png
11-01-14 01:13	Coruja	Note Added: 0001893
11-01-14 16:12	XuN	Note Added: 0001895
11-01-14 16:12	XuN	Assigned To	=> XuN
11-01-14 16:12	XuN	Status	new => assigned
12-01-14 00:16	XuN	Note Added: 0001896
12-01-14 00:16	XuN	Status	assigned => resolved
12-01-14 00:16	XuN	Resolution	open => fixed
14-01-14 20:55	Coruja	Note Added: 0001907
14-01-14 20:55	Coruja	Status	resolved => feedback
14-01-14 20:55	Coruja	Resolution	fixed => reopened
15-01-14 00:35	XuN	Note Added: 0001909
15-01-14 00:35	XuN	Status	feedback => resolved
15-01-14 00:35	XuN	Resolution	reopened => fixed