0002262: f_onchar_create can't read the char name anymore

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002262

SphereServer

executable - windows build

public

14-01-14 21:29

16-01-14 15:56

Reporter

Coruja

Assigned To

XuN

Priority

normal

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0002262: f_onchar_create can't read the char name anymore

Description

On last nightly (14 jan) the function f_onchar_create can't get the char name anymore

// This function is called after client created a new char.
// SRC --> char being created
// ARGN1 --> flags
// ARGN2 --> profession chosen
// ARGN3 --> race (1=human, 2=elf, 3=gargoyle)
// ARGS --> account name
// ARGO --> the client creating the character
// RETURN
// 0 --> normal action (create character)
// 1 --> denyes creation
[FUNCTION f_onchar_create]
SERV.LOG Char name: <SRC.NAME> / UID: <SRC>

this will return the SRC without problems, but the char name <SRC.NAME> will always be 'Man'. The correct behavior is return the name choosed on character creation menu

this could take some serious problems on shards which check all these names to prevent accounts choose duplicated char names :P

Tags

No tags attached.

Nightly Version

Automated (specify build number)

Experimental Flags

None

Option Flags

None

Internal Build Number

Attached Files

Relationships

Notes
(0001908) XuN (developer) 15-01-14 00:20	Fixed, all character data is being read before the function now.

(0001911) Coruja (developer) 16-01-14 07:32	lol maybe this change broke the return 1 on f_onchar_create :P return 1 disconnect and block the client to enter the game using the created char, but sphere doesnt really deny the char creation. After disconnect, if the client try to use the account again the char will be already created and ready to use

(0001912) XuN (developer) 16-01-14 15:55	Char is now deleted if creation is blocked.

Issue History
Date Modified	Username	Field	Change
14-01-14 21:29	Coruja	New Issue
15-01-14 00:20	XuN	Note Added: 0001908
15-01-14 00:20	XuN	Status	new => resolved
15-01-14 00:20	XuN	Resolution	open => fixed
15-01-14 00:20	XuN	Assigned To	=> XuN
16-01-14 07:32	Coruja	Note Added: 0001911
16-01-14 07:32	Coruja	Status	resolved => feedback
16-01-14 07:32	Coruja	Resolution	fixed => reopened
16-01-14 15:55	XuN	Note Added: 0001912
16-01-14 15:56	XuN	Status	feedback => resolved
16-01-14 15:56	XuN	Resolution	reopened => fixed