0002274: NPCs vendors revealing invisible GM accounts near

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002274

SphereServer

executable - windows build

public

03-02-14 00:44

06-02-14 19:23

Reporter

Coruja

Assigned To

XuN

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0002274: NPCs vendors revealing invisible GM accounts near

Description

On npc vendors, the msg 'npc_generic_interrupt' (from sphere_msgs.scp) is revealing invisible GM members near the npc

I mean, the player is talking (buy/sell/train/etc) to a npc, then I come near this same npc with my invisible GM account and the npc will say "Sorry xxxxx, but Coruja wanna talk with me". It will not remove the invisible flag, but the player will know that someone is there

Maybe a great way to fix this is use a simple CANSEE to make the npc say this message only to visible chars

Tags

No tags attached.

Nightly Version

Automated (specify build number)

Experimental Flags

None

Option Flags

None

Internal Build Number

Attached Files

Relationships

Notes
(0001940) XuN (developer) 05-02-14 15:39	I can't reproduce this, and the code is not revealing any issue related either... this text is called on NPC_OnHear() wich is called when you say anything and this npc hears it.

(0001942) Coruja (developer) 06-02-14 00:17	probably there's the mistery, I tried on my custom vendor, which open a dialog and the dialog button uses "HEAR something" to call others [EVENTS e_custom_vendor] //event running on vendor ON=@DClick FACE <SRC> ... SDIALOG d_vendor [DIALOG d_vendor button] ON=0 FACE <SRC> BOW ON=1 HEAR browse ON=2 HEAR collect ON=3 ... So now I dont know if it's really a bug, I already fixed removing this msg from sphere_msgs. But it would be great a simple 'cansee' check because it doesn't makes sense if someone say "Sorry but I must talk to xxx" if this player xxx cant seen by anyone. Even really using a spoken command (onhear) the player can use hidding/invisibility or just run away :D

(0001943) XuN (developer) 06-02-14 19:23	It's not a bug, there is already a Cansee() check in the code so the npcs don't interact with invisible characters, however if I block it in the OnHear() inside code you couldn't make them use hear xxx while invisible, so I think it should be up to you block it or not with a simple if !(<statf>&statf_invisible).

Issue History
Date Modified	Username	Field	Change
03-02-14 00:44	Coruja	New Issue
05-02-14 15:39	XuN	Note Added: 0001940
05-02-14 15:39	XuN	Assigned To	=> XuN
05-02-14 15:39	XuN	Status	new => feedback
06-02-14 00:17	Coruja	Note Added: 0001942
06-02-14 00:17	Coruja	Status	feedback => assigned
06-02-14 19:23	XuN	Note Added: 0001943
06-02-14 19:23	XuN	Status	assigned => resolved
06-02-14 19:23	XuN	Resolution	open => fixed