| Anonymous | Login | Signup for a new account | 19-04-25 05:41 CEST |  |
| Main | My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |
| 0002343 | SphereServer | executable - windows build | public | 20-05-14 03:06 | 29-07-14 08:56 | |
| Reporter | Coruja | |||||
| Assigned To | XuN | |||||
| Priority | normal | Severity | minor | Reproducibility | always | |
| Status | resolved | Resolution | fixed | |||
| Platform | OS | OS Version | ||||
| Product Version | ||||||
| Target Version | Fixed in Version | 0.56c Nightly | ||||
| Summary | 0002343: Fishing skill | |||||
| Description | Trying to fix/improve the fishing skill, I found some small problems: 1) The fish is going to the ground, but the correct behavior is put it on backpack like any other harvest skill (mining, lumberjack, etc) 2) Duplicated fishing msg. On skill start, sphere uses the msg 'fishing_promt' (sphere_msgs.scp) but I think the correct behavior is use the skill PROMPT_MSG (sphere_skills.scp) like many others skills 3) The fishing max distance actually is 6 but the correct is 4 tiles 4) The correct fishing sound is 0364 5) I dont know how adapt this to current stroke engine, but the correct behavior for the skill is: -Action start (target on ground, anim will run -without sound-) -After 1.6s the splash effect/sound appears -There's only 1 stroke with 8.0s (not 3 strokes) | |||||
| Tags | No tags attached. | |||||
| Nightly Version | Automated (specify build number) | |||||
| Experimental Flags | None | |||||
| Option Flags | None | |||||
| Internal Build Number | ||||||
| Attached Files | ||||||
 Relationships |
|
 Relationships |
|
Notes |
|
|
(0002341) XuN (developer) 18-07-14 09:22 |
1: Feeh added something for it with actargx 2: Actually mining does that too 'MACEPICK_TARG', the difference is the show text. 3: Fixed 4: Fixed 6: @SkillStrokes are for crafting skills right now, skills are slightly different. -fixed -fixed? -The splash and sound arent fired when fishing succeed? So correct delay for fishing is 8.0 and the splash and sound are fired with a external timer? |
|
(0002343) Coruja (developer) 18-07-14 18:10 |
On sphere the fishing behavior is completely different, it keeps trowing the fishing pole for many times with small delays. The correct order must be like this timeline: 0.0s: char anim to use the fishing pole (ANIM 12, no sound) 1.5s: the splash appears on the water (EFFECT 2,0352D,4,16) and make the splash sound (SOUND 0364) 8.0s: push the fish and finish the action (no anim, no sound) the total action time is 8.0s with just 1 "skill stroke", the splash anim/sound is fired on a external 1.5s timer PS: the timer is 1.5s not 1.6s lol |
|
(0002346) XuN (developer) 19-07-14 10:06 |
I'll commit some changes: SKF_GATHER enabled, only fishing will have this flag in sphere_skills.scp, so now @Stroke and @SkillStroke can be used. @(Skill)Start and @(Skill)Stroke now uses act as a reference for the worldgem. @(Skill)Start have local.GatherStrokeCnt for gathering skills. Fishing delay is now 8.0 (1 stroke), the splash animation is softcoded in sphere_skills.scp since working with timerf in the source will complicate things a little. In the 'long and not even started' proccess of softcoding skills ... the sounds/animations (for fishing!) will be added in the skill's triggers. I think it's working fine but let me know if something goes wrong and then I'll add SKF_GATHER to Lumberjacking and Mining. |
|
(0002347) Coruja (developer) 20-07-14 03:21 |
thx, I sent the missing i_memory_fishing_splash on Fishing skill, everything is working fine now :D PS: on server resync I got 'Undefined keyword SKF_GATHER' console error, this SKF_GATHER value is missing on sphere_defs.scp |
|
(0002348) XuN (developer) 20-07-14 20:04 |
The item was already added in the bottom of the file :), thanks anyway. So is everything else working fine? i'll commit the sphere_defs.scp update and then start to convert the other 2 skills and trying to make SKF_GATHER somehow 'generic' to be plug & play in every skill. |
|
(0002349) Coruja (developer) 20-07-14 22:56 |
roflmao I didn't see it on the bottom of the file I merged both i_memory_fishing_splash, the one at the bottom doesn't fire the splash effect on players with GM=0, but it's working fine now RANGE and ACT is working fine too, but LOCAL.GatherStrokeCnt on @Start doesn't work, here I set local.GatherStrokeCnt=3 but it only does 1 stroke and at the end of this first stroke it fire a strange anim+sound instead continue to next stroke |
|
(0002350) XuN (developer) 22-07-14 11:50 |
Fixed those problems with strokes. How many delays and strokes does have lumberjacking and mining? |
|
(0002351) XuN (developer) 22-07-14 13:19 |
Commited already them, i'll change it if they are wrong. Look also at the scripts for the damages on weapons and feel free to adjust them :) |
|
(0002381) XuN (developer) 29-07-14 08:56 |
I asume its working OK, reopen if not. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 20-05-14 03:06 | Coruja | New Issue | |
| 18-07-14 09:22 | XuN | Note Added: 0002341 | |
| 18-07-14 18:10 | Coruja | Note Added: 0002343 | |
| 19-07-14 10:06 | XuN | Note Added: 0002346 | |
| 20-07-14 03:21 | Coruja | Note Added: 0002347 | |
| 20-07-14 20:04 | XuN | Note Added: 0002348 | |
| 20-07-14 22:56 | Coruja | Note Added: 0002349 | |
| 22-07-14 11:50 | XuN | Note Added: 0002350 | |
| 22-07-14 13:19 | XuN | Note Added: 0002351 | |
| 29-07-14 08:56 | XuN | Note Added: 0002381 | |
| 29-07-14 08:56 | XuN | Status | new => resolved |
| 29-07-14 08:56 | XuN | Fixed in Version | => 0.56c Nightly |
| 29-07-14 08:56 | XuN | Resolution | open => fixed |
| 29-07-14 08:56 | XuN | Assigned To | => XuN |
|
Issue History |
| Copyright © 2000 - 2010 MantisBT Group |
 |